Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a script to populate the Setter contract #52

Merged
merged 8 commits into from
May 15, 2024
Merged

Add a script to populate the Setter contract #52

merged 8 commits into from
May 15, 2024

Conversation

konnov
Copy link
Contributor

@konnov konnov commented May 15, 2024

This PR adds a bash script for populating the Setter contract with data, so we can use it in our integration tests.

@konnov konnov requested review from thpani and andrey-kuprianov May 15, 2024 09:08
@konnov konnov self-assigned this May 15, 2024
@konnov konnov added the devops All kinds of devops-y activities label May 15, 2024
@konnov konnov added this to the M1: Transaction extractor milestone May 15, 2024
andrey-kuprianov
andrey-kuprianov reviewed May 15, 2024
View reviewed changes
Copy link
Collaborator

@andrey-kuprianov andrey-kuprianov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would only add that alice needs to be created as a prerequisite

@konnov
Copy link
Contributor Author

konnov commented May 15, 2024

LGTM. I would only add that alice needs to be created as a prerequisite

Fixed that. Please approve.

@konnov konnov merged commit 0f9a108 into main May 15, 2024
3 checks passed
@konnov konnov deleted the igor/setter-populate branch May 15, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-kuprianov andrey-kuprianov andrey-kuprianov left review comments

@thpani thpani thpani approved these changes

Assignees

@konnov konnov

Labels
devops All kinds of devops-y activities
Projects
None yet
Milestone
M1: Transaction extractor
Development

Successfully merging this pull request may close these issues.
3 participants
@konnov @thpani @andrey-kuprianov