the first working version of transaction fetcher #55
Conversation
| * @param matcher a quick matcher over the contractId to avoid expensive deserialization | ||
| */ | ||
| export async function extractContractCall( | ||
| op: any, |
There was a problem hiding this comment.
Is there no way to be more precise here?
There was a problem hiding this comment.
I am not actually sure. Stellar SDK has Operation, but it does not look like what Horizon API is returning in Stellar SDK. Some of the methods return sdk.Horizon.ServerApi.OperationRecord but it's not exactly compatible with what I need.
| @@ -64,7 +64,7 @@ impl SetterContract { | |||
| env.storage().instance().set(&MY_BOOL, &v); | |||
| log!(&env, "myBool: {}", v); | |||
| // bump the lifetime | |||
| env.storage().instance().extend_ttl(50, 100); | |||
| env.storage().instance().extend_ttl(env.storage().max_ttl() - 100, env.storage().max_ttl()); | |||
There was a problem hiding this comment.
+1, I had a similar question, but just assumed I was OOTL
There was a problem hiding this comment.
it's a threshold of when the TTL is to be updated. I am not exactly sure how it works, so it's a bit arbitrary.
There was a problem hiding this comment.
Makes sense. Could you add a brief comment? It looks a bit arbitrary.
There was a problem hiding this comment.
Added a comment. Actually, TTL is extended when it goes below the threshold, in this case, max_ttl - 100.
solarkraft/src/fetcher/storage.ts
Outdated
| returnValue: any | ||
| /** | ||
| * Ordered mapping from field names to their native values (JS). | ||
| * This mapping contains values only for the fields that have been set |
There was a problem hiding this comment.
So if I want all values after the tx, I have to merge oldFields and fields?
updatedFields may be a better name here.
There was a problem hiding this comment.
No, actually, fields contains all fields stored so far. It's basically the new state.
There was a problem hiding this comment.
Of course, if a contract removes a field from the storage, then fields will have fewer fields.
There was a problem hiding this comment.
I have updated the comments a bit
There was a problem hiding this comment.
Then I dont understand the comment (contains values only for the fields that have been set by transactions). Which fields aren't set then?
There was a problem hiding this comment.
Here is the fresh version. It's all modulo my understanding of how Soroban stores the storage in Stellar:
/**
* Ordered mapping from field names to their native values (JS).
* This mapping contains values only for the fields that have been created
* or updated by a transaction in the past. It may happen that `fields` contains
* fewer fields than `oldFields`, when the contract deletes some fields
* from the storage. Also, `fields` may become empty when the storage
* goes over TTL.
*/There was a problem hiding this comment.
Oh, you meant values that ever have been set! Understood, lg
| // https://developers.stellar.org/network/horizon/api-reference/resources/operations/object | ||
| if (op.function === 'HostFunctionTypeHostFunctionTypeInvokeContract') { | ||
| // This operation represents a smart contract call. |
There was a problem hiding this comment.
Can't you just return none if !==.
Bit hard to follow controlflow here with the indentation.
| const method = params[1] | ||
| const methodArgs = params.slice(2) | ||
|
|
||
| const tx = await op.transaction() |
There was a problem hiding this comment.
This is weird. Is it really async?
There was a problem hiding this comment.
yeah, it looks async. Basically, SDK makes another call to the server.
| const methodArgs = params.slice(2) | ||
|
|
||
| const tx = await op.transaction() | ||
| // is it the right way to extract the height? |
There was a problem hiding this comment.
I mean, yeah. I hope someone more knowledgeable would read it tells me to fix it :)
There was a problem hiding this comment.
added TODO: for the future
| `Expected TransactionMetaV3, found ${meta.switch()}: txHash = ${txHash}` | ||
| ) | ||
| return none() | ||
| } else { |
There was a problem hiding this comment.
Also here, I don't think you need to nest inside else, since you return above?
There was a problem hiding this comment.
yeah, good catch. It grew too large organically. Pruned it
|
I will merge this one to continue with the storage. |
This PR presents a working implementation of transaction decoder. The core of this contribution is:
solarkraft/src/fetcher/callDecoder.tsextracts Soroban contract calls from a Horizon API.solarkraft/src/fetcher/storage.tsis the basic storage data structure that is returned bycallDecoder.solarkraft/test/integration/callDecoder.test.tsis an integration test that fetches data from the testnet and compares the results to the expected outputs.solarkraft/src/fetch.tsis work-in-progress code, ignore it.The integration test is fragile as the test data will disappear after 1 month or when the testnet is reset. We have to find a more stable solution. However, for the development purposes, it should work.