add ADR002 to document the storage #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kukovec
reviewed
May 16, 2024
|
|
||
| - It should be relatively easy to order these transactions, e.g., by ledger height. | ||
|
|
||
| - Transactions that happen in the same block should not collide. |
There was a problem hiding this comment.
What do you mean by "collide"? In the database sense, have the same primary key?
There was a problem hiding this comment.
yeah, basically, the block number cannot be used as the unique identifier
thpani
approved these changes
May 16, 2024
| Given all these requirements, we store every contract call in its own file called: | ||
|
|
||
| ``` | ||
| ${STOR}/${contractId}/${height}/entry-${txHash}.json |
There was a problem hiding this comment.
So you want to say anything about the content format of these files?
Even if it's just pointing to the implementation, I think it would be helpful.
Co-authored-by: Kukovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents a simple design for storing the transactions that are to be extracted by the fetcher.