Adds programmatic alert contract invocation #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpani
reviewed
May 22, 2024
solarkraft/package.json
Outdated
| @@ -30,14 +30,15 @@ | |||
| "dist/**/*" | |||
| ], | |||
| "scripts": { | |||
| "alert": "mocha --timeout 0 --loader=ts-node/esm test/alert/**/*.test.ts", | |||
There was a problem hiding this comment.
Why not put it under e2e which already exists?
There was a problem hiding this comment.
Well, partially because it's not really end-to-end, more like mid-to-end, but more prominently, because this way it gets a separate timeout flag, since it's currently doing some back-and-forth requests each time, and so the test takes longer than all the rest (which have a default of 2s timeout)
There was a problem hiding this comment.
You can set the timeout. See the current e2e tests
thpani
reviewed
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67
Adds a method
invokeAlert, which submits the monitor analysis status to the alert contract.Calling
invokeAlertrequires a knownsorobanRpcServer, as well as an account/keypair with which to sign/submit transactions. In the test, the latter are randomly generated and funded, but we should probably hardcode them to cut down on response waiting times.