-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified instrumentation #82
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpani
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I'm a bit scared about the empty conjunction (see my comment below) if the code evolves.
Co-authored-by: Thomas Pani <[email protected]>
Co-authored-by: Thomas Pani <[email protected]>
@thpani just fyi, it seems like the |
thpani
added a commit
that referenced
this pull request
Jun 12, 2024
We now have support for missing fields: #82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #81
This PR changes instrumentation, to the format discussed during our recent meeting. A detailed explanation of the format can be found inside
instrument.ts
.To this end, it makes the following changes:
Init
fromoldFields
, andNext
from a conjunction of state-variable updates fromfields
and transition constraints frommethod
andmethodArgs
.Gen(1)
initializations (in eitherInit
orNext
) to all variables declared in the monitor, but absent from the transaction data (inoldFields
orfields
, respectively). This allows us to avoid Apalache errors on transactions in which data storage changes.entry-timelock.json
has been fixed to comply with the transition requirements ofClaim
(last_error' = "contract is not initialized"
whenever~is_initialized
)