Fetch and instrument block timestamp #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `verify` writes back the verification result, this would duplicate the entry. Thus, we have to store it under its contract address from the beginning.
It's formatted this way by e2e `verify` writing back the verification result.
Kukovec
approved these changes
May 29, 2024
| // https://docs.rs/soroban-sdk/latest/soroban_sdk/ledger/struct.Ledger.html#method.timestamp | ||
| // according to [this](https://stellar.stackexchange.com/questions/1852/transaction-created-at-and-ledger-close-time), | ||
| // the transaction object's `created_at` equals the ledger's `closed_at`. | ||
| const timestamp = new Date(op.created_at).getTime() / 1000 |
There was a problem hiding this comment.
Do we need the /1000 here? I understand that it says here that the time is given in seconds, but in a degenerate case it could happen that Date(t1).getTime() and Date(t2).getTime() are different in ms units but same in s units due to truncation.
There was a problem hiding this comment.
Horizon only gives us seconds precision, it's just that Date (which we use for parsing) internally represents milliseconds.
We could leave it as milliseconds here, but I think it's preferable to have parity between the spec and the contract code (in case there are any constants).
I agree though that this looks confusing. I'll add a comment for clarification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch and instrument the block timestamp, which is available in Soroban as
env.ledger().timestamp().Also modifies and moves around some e2e test assets, to match the repository after running
npm run e2e. This is the result of (a) including time stamps and (b) writing back the verification result inverify.Finally I'm moving an
rmSync()call to keep the JSON TLA+ for debugging purposes, in case Apalache fails.