-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install the private/v80.h header file #59
base: master
Are you sure you want to change the base?
Conversation
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/freeswitch/spandsp/60/index.html |
I got to the same problem when building freeswitch. Thank you @tmancill for the solution. Can this PR be accepted sooner so the master branch becomes usable in the freeswitch build? I saw CI errors and they are irrelevant to this PR. |
thank you for the solution. |
This is pull request is definitely needed for FreeSWITCH 1.10.10. Experienced the same problem. Agreed that tags or releases would be really helpful. |
Can confirm the same here. Also very much agree on tagging versions, it's now either pinning a specific commit or patching this manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The missing include does break compilation of freeswitch, and this simple patch fixes it!
Note that freeswitch itself ALSO needs fixes - see ticket signalwire/freeswitch#2282 and linked patch |
Hi. I noticed this when attempting to build freeswitch. It looks like
private/v80.h
needs to be installed along withexpose.h
. The reference to private/v80.h was added in d8dfbd7.This PR also includes a tweak to autogen.h, which carps about the
./config
directory that already exists. I'm happy to split that into a separate PR, or modify this one to remove themkdir
entirely. I'm not sure under what circumstance the directory wouldn't exist since it is part of the repo.