gluon-core: set 5GHz rssi leds to mesh1 connectivity #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missing for quite some time. For example the dap-x1860 profits from using its LEDs to show the mesh connectivity. Signed-off-by: Florian Maurer <[email protected]>
maurerle
force-pushed
the
rssi_for_5ghz
branch
from
685e989 to
4e2188a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RSSI LEDS on 5GHz in openwrt did not work for gluon as they were set to
wlan1which does not exist.For example the dap-x1860 profits from using its LEDs to show the mesh connectivity on 5GHz through the LEDs.
This of course is only limited to show the connectivity on radio1 if possible.
This might as well be misleading in situations where radio1 does not mesh and the turned off connectivity is interpreted wrongly.
Though I don't think there is a better approach than using it for mesh1 and I do think it is a nice feature and should be enabled by default :)
Tested on a DAP-X1860 in combination with a COVR-X1860 - works great to show if a neighbor on mesh1 is visible