Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylinted the SynthHD #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pylinted the SynthHD #9

wants to merge 1 commit into from

Conversation

fretchen
Copy link
Owner

There are still a few weird things in the code. Quite importantly as I run pylint right now he gives me:

pylint SynthHDDevice
************* Module SynthHDDevice
SynthHDDevice/__init__.py:1:0: C0103: Module name "SynthHDDevice" doesn't conform to snake_case naming style (invalid-name)
************* Module SynthHDDevice.blacs_tabs
SynthHDDevice/blacs_tabs.py:10:0: W0223: Method 'start_run' is abstract in class 'DeviceTab' but is not overridden (abstract-method)
************* Module SynthHDDevice.blacs_workers
SynthHDDevice/blacs_workers.py:19:4: W0231: __init__ method from base class 'Worker' is not called (super-init-not-called)
************* Module SynthHDDevice.labscript_devices
SynthHDDevice/labscript_devices.py:30:8: C0103: Attribute name "BLACS_connection" doesn't conform to snake_case naming style (invalid-name)
SynthHDDevice/labscript_devices.py:20:46: W0613: Unused argument 'baud_rate' (unused-argument)
  • The first important one is that the baud_rate is never used. Why ?
  • The second weird one is that the __init__ function is called for the worker instead of init like for all the other workers in other devices. Why?

There are still a few weird things in the code.
@fretchen fretchen requested a review from nalilab April 17, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant