Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md: Typos, Imports #28

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

takahser
Copy link
Contributor

  • PR scope: fix typos, add missing imports to code example
  • also, I noticed that you chose the namings KeyedTree and IndexTree and I think, IndexedTree would be more consistent here. But since this would require some refactoring, I didn't make any corresponding changes.

fix typos, add missing imports to code example
@frisitano
Copy link
Owner

  • PR scope: fix typos, add missing imports to code example

Thank you for the contribution!

  • also, I noticed that you chose the namings KeyedTree and IndexTree and I think, IndexedTree would be more consistent here. But since this would require some refactoring, I didn't make any corresponding changes.

I had initially considered IndexedTree but chose IndexTree instead. Upon reflection I think that was the wrong decision. I agree with you that IndexedTree is more consistent. I've added an issue to change this for the next version: #29 .

Copy link
Owner

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fixes!

@frisitano frisitano merged commit 9a0035c into frisitano:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants