-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review for Fritz #17
Open
fritzo
wants to merge
7
commits into
fritzo:master
Choose a base branch
from
pomagma:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Review for Fritz #17
Commits on Oct 7, 2014
-
Editor does not know about menu
Menu API simplified Renamed navigator => menuRenderer Menu does not know about menuRenderer
Configuration menu - View commit details
-
Copy full SHA for b1eaedb - Browse repository at this point
Copy the full SHA b1eaedbView commit details
Commits on Oct 21, 2014
-
* editor does not care about view or menu
* old puddle-syntax removed * view and menu code refactored * keycode replaced with keypressJS lib
Configuration menu - View commit details
-
Copy full SHA for 41ea672 - Browse repository at this point
Copy the full SHA 41ea672View commit details
Commits on Nov 7, 2014
-
This is a big change to client side libraries API.
Editor.js is now split among cursor.js, menu-builder.js, forest.js Event listener is used across libraries to notify each other of events. See reference.md for better description.
Configuration menu - View commit details
-
Copy full SHA for ff21837 - Browse repository at this point
Copy the full SHA ff21837View commit details
Commits on Dec 9, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 8d9a1b5 - Browse repository at this point
Copy the full SHA 8d9a1b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for eaf43f5 - Browse repository at this point
Copy the full SHA eaf43f5View commit details
Commits on Dec 11, 2014
-
Refactor the way cursor is injected into the term and removed from term. Cursor injection simplified in view.js
Configuration menu - View commit details
-
Copy full SHA for 3de8cca - Browse repository at this point
Copy the full SHA 3de8ccaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5553be8 - Browse repository at this point
Copy the full SHA 5553be8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.