РК 1 #10
Merged
РК 1 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Переработки по роутингу №1
Cia 10 routing
Верстка страниц
Простая система хедера, валидация
Связь с бэком, прочие UX удобства
…ed кнопки, удаление debug инфы.
ValdimirDenisov
requested changes
Mar 9, 2025
| </svg> | ||
| </a> | ||
| <a class="header__notice-href" href="/"> | ||
| <svg width="100%" height="100%" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 448 512"> |
There was a problem hiding this comment.
Вынесите svg иконки в отдельный файл, так не стоит делать.
Просто создайте файлик name.svg и крепите их в html при помощи img или css свойств
| </svg> | ||
| </a> | ||
| <a class="header__notice-href" href="/"> | ||
| <svg width="100%" height="100%" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 448 512"> |
There was a problem hiding this comment.
Вынесите svg иконки в отдельный файл, так не стоит делать.
Просто создайте файлик name.svg и крепите их в html при помощи img или css свойств
| <div class="overlay"> | ||
| <div class="login"> | ||
| <div id="loginCloseButton" class="login__close"> | ||
| <svg width="100%" height="100%" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
Вынесите svg иконки в отдельный файл, так не стоит делать.
Просто создайте файлик name.svg и крепите их в html при помощи img или css свойств
ValdimirDenisov
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.