borders for the item icon and aura icons + various options relating to that

[NoBetaBoredom]

I implemented borders for the item icon and the aura icons. It just copies the borderstyle of the parent tooltip. Additionally I added various options for the auras:

• X and Y offsets for the aura icons
• border colors, either copy the border color of the parent tooltip, or set custom colors for buffs and debuffs
• current behaviour with only debuffs having a border is still available

The borders are pixel-perfect and align perfectly with the parent tooltip, no shuffling or jumping at all. Max aura count per row etc. also works.

This includes #47 if you want to merge both, otherwise I can rebase this later if this is not acceptable yet.

How my tooltips look now as an example (censored):

Edit: additional changes in this branch:

• option to use the default blizz colors instead (DebuffTypeColor)
• positive insets correctly work for aura and item icons
• comparing items are positioned with item icons in mind
• tooltip item and aura icons are also clamped to the screen now

[NoBetaBoredom]

I also fixed item comparisons, they now take the itemicon and position into account:

Let me know if you want me to split this into different PRs.

Edit: now works on retail too, I only tested on tbcc initially. I also noticed that the first line of text in tooltips is a bit jumpy only on retail, not sure why.
Edit2: nvm, the jumpiness goes away once I activate the "UI Scale" option in the graphics settings - perfect again!

[frozn]

I pushed out a new release (v22.02.09) to a) make available the latest bugfixes to stabilize the actual version and b) freeze this version before I include your extensive changes, because I will need some time for that. 💪

[NoBetaBoredom]

I went ahead and made pixel-perfect scaling/positioning/offsets for the aura icons an option, since you probably wouldn't have added it as default.
Also changed the implementation to just scaling the aura frames themselves. Cleaner, but not as clean as I want it to be, especially for calculating the clamping rect. I tried to implement clamping by setting the icons themselves to be clamped, but unfortunately that just makes them move away from their anchor instead. Not sure if it's possible to clamp 2 anchored frames that keep their anchors/offsets.

[glassleo]

How about adding Masque support instead? It'd be really nice if I could have my tooltip icons match the rest of my UI.

[frozn]

Looks interesting. I would move this enhancement to a separate issue. I think displaying and styling of tooltip icons/auras should work out of the box without an external library by default. Using Masque would be optional (e.g. would add a checkbox for it in options).

[glassleo]

Looks interesting. I would move this enhancement to a separate issue. I think displaying and styling of tooltip icons/auras should work out of the box without an external library by default. Using Masque would be optional (e.g. would add a checkbox for it in options).

More options are not bad, but instead of doing all this work you could just implement Masque which does all of this out of the box with way more customization. It is widely supported by most major addons that have any sort of icon displays (WeakAuras, Bartender, OPie, Raven, etc, etc) so many people already use it for other addons... No need to reinvent the wheel.

[frozn]

I have taken a look at WeakAuras and Bartender4. Masque is an optional dependency here. They have also implemented an alternative way of displaying the buttons if Masque is missing.

But I know what you mean... 😉

[NoBetaBoredom]

No need to reinvent the wheel.

It's work that has to be done anyways, it just adds borders that were not there before. Masque support can always be added afterwards. The other option that provides pixel-perfect scaling/positioning/offsets also has to be implemented because Masque doesn't provide that (from a quick search I did, you always have to make sure the icons are already correctly scaled to have pixel-perfect skins).

[glassleo]

It's work that has to be done anyways, it just adds borders that were not there before. Masque support can always be added afterwards. The other option that provides pixel-perfect scaling/positioning/offsets also has to be implemented because Masque doesn't provide that (from a quick search I did, you always have to make sure the icons are already correctly scaled to have pixel-perfect skins).

True. Scaling and positioning would be really nice to have!

[HiMarioLopez]

Any updates on this PR? Was just running into some issues related to the tooltips and the ideas behind it are still very much wanted! Wondering if the implementation details ever got figured out. @frozn

^ Some item tooltip stuff I'm seeing today (missing styles, somehow a duplicate item tooltip icon).

Cheers

[frozn]

Yes, this feature is still nice to have and I want to implement this sometime. But because my spare time is limited and other issues (e.g. after patches) are more important, I haven't had the chance to do it yet. 🙁

[HiMarioLopez]

Mate, no worries. Thank you for your diligent work on such an amazing tool. Looking forward to future updates!