-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quickjspp v2 #45
base: master
Are you sure you want to change the base?
quickjspp v2 #45
Conversation
# Conflicts: # quickjspp.hpp
looks great, will give it a try when ready :) |
# Conflicts: # quickjspp.hpp # test/class.cpp
# Conflicts: # quickjspp.hpp
thanks to egoarka for reporting
small bit of feedback, i tried implementing this branch over last weekend to see how itd go with the changes. requiring classes to be inherited from |
@samhellawell I'm agree with you !
|
This changes the way pointers are stored in JS objects.
std::shared_ptr<T>
T
std::shared_ptr<T>
conversionqjs::shared_ptr<T>
conversionT*
conversionqjs::enable_shared_from_this<T>
as base classnew
,std::make_shared
qjs::make_shared
current v2 limitations:
qjs::make_shared
needs JSContextqjs::shared_ptr
instances need to be destroyed before js context is destroyedAlso fixes bugs where JS properties are not saved