Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new formatting plugin system, new Compact formatting plugin #81

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SinusPi
Copy link
Contributor

@SinusPi SinusPi commented Nov 15, 2022

  • added support for formatting plugins, able to modify the display of Message, Stack and Locals.
  • "Compact" formatting plugin included, with an explanatory screenshot.
  • switching of plugins is available in the config panel.

@SinusPi
Copy link
Contributor Author

SinusPi commented Nov 15, 2022

Well, good job me, forgot to add the one file core to the idea.

@funkydude
Copy link
Owner

Nice work! I'll take a proper look at this later but for now I did a quick skim:

  • Remove the image, don't think we need this
  • The hard-embedded kind of half-library code should just be merged into the core addon and not used as a library
  • The new files are missing newlines at the end

@SinusPi
Copy link
Contributor Author

SinusPi commented Nov 20, 2022

  • The image was there just for illustration purposes, probably should've been just part of a comment.
  • I was undecided on the parsing half-lib. Very well, moving it into the main file space.

@funkydude
Copy link
Owner

Sorry I totally forgot about this. Are you still interested in working on it?

@SinusPi
Copy link
Contributor Author

SinusPi commented Jan 28, 2023

Time permitting, sure - but I thought I brought it to a workable state already.

@MyTechnoHunter
Copy link

as a followup, i grabbed the PR and tested it, changing the formatter dropdown from anything to raw causes an error.

10x Interface/AddOns/BugSack/core.lua:247: bad argument #1 to 'format' (string expected, got nil)

Stack:
[string "=[C]"]: in function format' [string "@Interface/AddOns/BugSack/core.lua"]:247: in function FormatError'
[string "@Interface/AddOns/BugSack/sack.lua"]:90: in function <Interface/AddOns/BugSack/sack.lua:32>
[string "@Interface/AddOns/BugSack/sack.lua"]:128: in function <Interface/AddOns/BugSack/sack.lua:124>
[string "=[C]"]: ?
[string "=[C]"]: in function UpdateDisplay' [string "@Interface/AddOns/BugSack/config.lua"]:78: in function func'
[string "@Interface/SharedXML/UIDropDownMenu.lua"]:1007: in function `UIDropDownMenuButton_OnClick'
[string "*UIDropDownMenuTemplates.xml:136_OnClick"]:1: in function <[string "*UIDropDownMenuTemplates.xml:136_OnClick"]:1>

Locals:
(*temporary) = "

Stack:
%s"
(*temporary) = nil
(*temporary) = "string expected, got nil"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants