chore: Remove isahc

fussybeaver · Oct 17, 2024 · edf33c2 · edf33c2
1 parent eaa0703
commit edf33c2
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 135 deletions.
diff --git a/.github/workflows/default.yml b/.github/workflows/default.yml
@@ -22,12 +22,6 @@ jobs:
         with:
           command: check
 
-      - name: Run cargo check isahc
-        uses: actions-rs/cargo@v1
-        with:
-          command: check
-          args: --features isahc --target x86_64-unknown-linux-gnu
-
       - name: Run cargo check reqwest
         uses: actions-rs/cargo@v1
         with:
@@ -85,12 +79,6 @@ jobs:
           toolchain: stable
           override: true
 
-      - name: Run cargo test isahc
-        uses: actions-rs/cargo@v1
-        with:
-          command: test 
-          args: --features isahc --target x86_64-unknown-linux-gnu
-
       - name: Run cargo test reqwest
         uses: actions-rs/cargo@v1
         with:

diff --git a/Cargo.toml b/Cargo.toml
@@ -32,9 +32,6 @@ serde_urlencoded = { version = "0.7" }
 thiserror = "1"
 log = "0.4"
 
-# isahc 
-isahc = { version = "1", optional = true, features = ["json"] }
-
 # reqwest
 reqwest = { version = "0.12", optional = true, features = ["json"] }
 

diff --git a/src/adapters/isahc.rs b/src/adapters/isahc.rs
diff --git a/src/adapters/mod.rs b/src/adapters/mod.rs
@@ -3,17 +3,6 @@ use serde::{ser, Deserialize};
 
 use crate::auth::Auth;
 
-#[cfg(feature = "isahc")]
-pub mod isahc;
-
-#[cfg(feature = "isahc")]
-pub use self::isahc::AdapterError;
-
-#[cfg(feature = "isahc")]
-pub(crate) use {
-    self::isahc::fetch, self::isahc::fetch_async, self::isahc::to_json, self::isahc::to_json_async,
-};
-
 #[cfg(target_arch = "wasm32")]
 pub mod wasm;
 
@@ -42,7 +31,6 @@ pub use self::ureq::AdapterError;
 pub type Req = http::Request<Vec<u8>>;
 
 #[cfg(all(
-    not(feature = "isahc"),
     not(feature = "reqwest"),
     not(feature = "ureq"),
     not(target_arch = "wasm32")
@@ -51,18 +39,13 @@ pub type Req = http::Request<Vec<u8>>;
 pub enum AdapterError {}
 
 #[cfg(all(
-    not(feature = "isahc"),
-    not(feature = "isahc"),
-    not(feature = "isahc"),
     not(feature = "reqwest"),
     not(feature = "ureq"),
     not(target_arch = "wasm32")
 ))]
-    not(feature = "isahc"),
 pub type Req = http::Request<Vec<u8>>;
 
 #[cfg(all(
-    not(feature = "isahc"),
     not(feature = "reqwest"),
     not(feature = "ureq"),
     not(target_arch = "wasm32")
@@ -88,7 +71,6 @@ impl GitHubResponseExt for http::Response<Vec<u8>> {
 }
 
 #[cfg(all(
-    not(feature = "isahc"),
     not(feature = "reqwest"),
     not(feature = "ureq"),
     not(target_arch = "wasm32")
@@ -100,7 +82,6 @@ impl<C: Client> GitHubRequestBuilder<Vec<u8>, C> for http::Request<Vec<u8>> {
 }
 
 #[cfg(all(
-    not(feature = "isahc"),
     not(feature = "reqwest"),
     not(feature = "ureq"),
     not(target_arch = "wasm32")