New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/pre commit typo mypy updates #73

Open

proudfeet wants to merge 2 commits into fuzzylabs:develop from proudfeet:bugfix/pre-commit-typo-mypy-updates

proudfeet commented Sep 7, 2023

This PR closes MindGPT-72.

Addresses minor issues with pre-commit where:

Configuration of typo was not correctly inherited from _typo.yaml
Historic type ignore comments, aimed to suppress mypy failures, were still in place for requests_html

Changes result in successful pre-commit run against all files in repo (as per configuration), using pre-commit run --all-files.

The typo fix is not an optimal solution but will do the job until the root issue is fixed here.

proudfeet added 2 commits

September 7, 2023 20:26


          Updated typos pre-commit config to match _typo.toml.

63cbeaa


          Removed old type ignore comments

5e6b0cd

proudfeet mentioned this pull request

Enhancement/improved dependency management #76

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet