Changing cache file rigths to 666 so that different users on the same…

[ivanprado]

… machine could use it concurrently.

Otherwise, it fails at initialization and cache is not used so there are no initialization gains in the case of two different users running the library in the same machine.

[kmike]

To give more details: currently temporary cache file is created with permissions which allow reading and writing only for the current user. It is then moved to the global temp dir (/tmp on Linux), with the same permissions. Once the file is created by one user, other users can't overwrite it. What's worse, they can't even read it. So once cache file is created, jieba cache stops working for all other users, they're getting a traceback in logs each time.

[gumblex]

Write permission for other users can be a security risk because marshal files cannot be securely loaded.

[ivanprado]

I understand. You are right. Then I propose to add a username to the default jieba config file, so that each user has its own cache file. Something like this: ```python cache_file = 'jieba.cache.{}'.format(os.getuid()) ``` What do you think? An alternative is to give only read permission... but what if a user needs to refresh the cache or something like that? I think is better to have one file per user.

…

On Thu, Nov 8, 2018 at 10:01 AM Dingyuan Wang ***@***.***> wrote: Write permission for other users can be a security risk because marshal files cannot be securely loaded. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#686 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA2q6EuM_iXZ97q2tC3b8djOm5ZgL8cCks5utADigaJpZM4YS3bU> .