Process events in runloop only when needed #4399
Conversation
|
|
||
| postEmptyEvent() | ||
|
|
||
| eventTick := time.NewTicker(time.Second / 60) // TODO: Why does it not work without this? |
There was a problem hiding this comment.
I get no window without this ticker and I just don't understand why. If the glfw.WaitEvents() method blocks as it's supposed to, surely this loop won't run more times because we have a ticker (that in theory ought to make sure run less compared to a bare for {})?
There was a problem hiding this comment.
Are you saying it works with the ticker but not the bare for{}?
If so my guess would be that its blocking the posting of other events that you're expecting will wake it up.
You could test by switching to [glfwWaitEventsTimeout](https://www.glfw.org/docs/3.3/group__window.html#ga605a178db92f1a7f1a925563ef3ea2cf)(0.7); and see if it helps
There was a problem hiding this comment.
Are you saying it works with the ticker but not the bare for{}?
Yup. I am worried that glfwWaitEventsTImout will be just as bad as the previous code unless we have a very long timeout.
There was a problem hiding this comment.
It was not meant as a solution, merely more data for debugging
There was a problem hiding this comment.
I think postEmtpyEvent at line 120 needs to be in a goroutine so that we have called waitEvents before postEmptyEvent is called. Doing that seems to launch the window in my testing without using the ticker.
The real challenge is figuring out everywhere we would now need to PostEmtpyEvent to wake up the main thread. Especially on ARM Mac where we draw on the main thread it will be a challenge, since the waitEvents call will need to be woken up whenever there's something that needs to be drawn/refreshed.
There was a problem hiding this comment.
Ah, cool. I'll keep that in mind and look at this once again going forward
|
|
||
| postEmptyEvent() | ||
|
|
||
| eventTick := time.NewTicker(time.Second / 60) // TODO: Why does it not work without this? |
There was a problem hiding this comment.
Are you saying it works with the ticker but not the bare for{}?
If so my guess would be that its blocking the posting of other events that you're expecting will wake it up.
You could test by switching to [glfwWaitEventsTimeout](https://www.glfw.org/docs/3.3/group__window.html#ga605a178db92f1a7f1a925563ef3ea2cf)(0.7); and see if it helps
|
Closing in favour of #5422. |
Description:
This PR changes the run loop to use
glfw.WaitEvents()instead and useglfw.PostEmptyEvent()when necessary to only ever process events when there are any to process.This specific PR is a rebase of #4173. It was easier to start fresh.
Fixes #2506
Checklist: