Embed theme contents instead of bundle #5443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This has code modernisation has various benefits. A shallow git clone of the project no longer includes all icons twice (in source and .go file), opening the huge files with bundled stuff no longer cause editors to grind to a halt but most importantly, just editing the file makes the data in the binary change without needing to do anything at all. It is all automatic and cached by the compiler. There is also less text for the compiler to parse so there might be faster compile times (assuming it can just copy the file directly into the binary) but that's just speculation.
Building
fyne_demo
usinggo build -ldflags="-s -w"
yields:Binaries are ever so slightly larger but we are just talking ~30kb so nothing much to write home about.
Checklist: