Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up cleanup function queue in fyne_demo #5459

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Clean up cleanup function queue in fyne_demo #5459

merged 2 commits into from
Jan 25, 2025

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Jan 24, 2025

Description:

Right after having merged and read #5450 (review), I realised that the checks and page input string just was a leftover from before I cleared the queue of functions after having executed them. This means that I can just remove that part and use func() directly.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

andydotxyz
andydotxyz approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaner :)

@coveralls
Copy link

Coverage Status

coverage: 59.075% (-0.001%) from 59.076%
when pulling 03a7eac on Jacalz:demo-cleanup-queue
into 77089e6 on fyne-io:develop.

@Jacalz Jacalz merged commit cc8163c into fyne-io:develop Jan 25, 2025
11 checks passed
@Jacalz Jacalz deleted the demo-cleanup-queue branch January 25, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jacalz @coveralls @andydotxyz