-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only refresh scroll chrome when scroller is resized #5472
Conversation
This is a good change (though haven't tested it yet) but just noting that it doesn't fix #5456 - the root cause there is the widgets themselves. e.g. here in Tree, it refreshes the entire content in the OffsetUpdated callback from the scroller: https://github.com/fyne-io/fyne/blob/develop/widget/tree.go#L491 (and similarly in table) Also doing a full refresh on any resize here: https://github.com/fyne-io/fyne/blob/develop/widget/tree.go#L593 |
Widget.Refresh running thread handling code was not great for potential loop scenarios
It's a shame - in my testing this was night and day difference - using the split in fyne_demo is really laggy on develop and smooth with this PR applied. Yes there is an "over refresh" in there still - but it's the lesser of the two. Maybe there are two different fixes to the issue reported as the resize and scroll refreshes do not have the same root cause? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looking really good. Just a small change I think you accidentally left in there (or due to being based on the wrong commit compared to develop).
Progresses #5456
Checklist: