Fixing Scroller.ScrollToTop, alias to a new fyne.ScrollDirection type and align all collections on ScrollToOffset #5477
+134
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacalz
reviewed
Jan 31, 2025
scroll.go
Outdated
| ScrollVerticalOnly | ||
| // ScrollNone turns off scrolling for this container. | ||
| // | ||
| // Since: 2.6 |
There was a problem hiding this comment.
All of these above are new within the fyne package scope. I understand why this was added here but it is slightly confusing 😅
There was a problem hiding this comment.
I get your point but what would be more correct? I can switch to whatever you suggest, but I'm not sure what is right.
There was a problem hiding this comment.
I'd suggest adding the line to the type only as it is new in this release but I don't know really.
There was a problem hiding this comment.
That works, done thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: