commands/package-web: check go1.24 ./lib/wasm/ for wasm_exec.js #5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdecaf
added a commit
to adamdecaf/watchman
that referenced
this pull request
Feb 24, 2025
We're forced to compile on go1.23.x until fyne-io/fyne#5551 is merged
Jacalz
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Given that the changes are copied over from https://github.com/fyne-io/tools/pull/38/files, would you mind adding me as co-author and linking to that PR please?
Co-authored-by: Jacalz <[email protected]>
adamdecaf
force-pushed
the
fix-go1.24-wasm_exec-path
branch
from
c46d0f2 to
93ea670
Compare
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #5549
Description:
Go 1.24 changed the location of
wasm_exec.jsunder GOROOT.Checklist: