load markdown images from origin when not a URL #5579
+48
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkparker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Markdown supports loading local images off disk. Currently, in fyne, when in the web, this doesn't work, because the browser can't access the local file system like that. However, what I've seen from other markdown implementations is that in the web, a "local" file means from the same origin as the markdown file. For example
in a markdown loaded fromfyne.ioshould be interpreted as.This change adds that behavior to Fyne's markdown parser. This has been tested locally for a website I'm working on with Fyne.
Checklist: