-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Terminal Character Bugs. #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch thanks, just a question inline about reducing appends.
This is having some issues still. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, not sure about one of the optimisations though.
Refresh not Resize for the previous commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :) I appreciate your work on this project
Fix for #9
The buffer cuts some chars in half since UTF-8 isn't always 1 byte.
Returning the byte and prepending it to the next buffer fixes the issue.
Also changed bufLen from 4069 to 4096.
Added:If columns or rows changes during handleOutput then break loop.
It looked like output was being fully rendered for every size change which was sluggish.