Run syntax checker during travis build #544
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to running unit tests, these additional checks ensure that certain failures will not make it into the code base unintentionally.
|
The pyflakes tool has been useful for me on various python project, so perhaps it may be useful here. There were only three minor warnings from pyflakes. Two of them are fixed in this pull request. The last I have not resolved, as I am not as familiar enough with the code. If running pyflakes is valuable, is the following issue something that could be resolved or is it a false positive: |
|
great work - i recommend using flake8 which includes pyflakes, among other checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to running unit tests, these additional checks ensure that
certain failures will not make it into the code base unintentionally.