Fix: as_las_string_lossy should ignore anything after the first null character #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just came across a las file with the following Extra-Attributes VLR:
The user_id is not properly filled with null characters (see the
\u{18}
hidden in there...). In this case,as_las_string_lossy
currently returns the full string including all null characters. This results in the extra-bytes VLR not being detected correctly in my own code. Most other tools like LasTools or CloudCompare seem to have no problem with this and just ignore anything after the first null character. I changedas_las_string_lossy
to work this way, too. Nowas_las_string_lossy
correctly parses above user id as "LASF_Spec".