fix: ignore imports with search params

gajus · Oct 12, 2023 · 0f9c153 · 0f9c153
1 parent 545558a
commit 0f9c153
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 0 deletions.
diff --git a/src/rules/requireExtension.ts b/src/rules/requireExtension.ts
@@ -291,6 +291,11 @@ export default createRule<Options, MessageIds>({
 
       const importPath = node.source.value;
 
+      if (importPath.includes('?')) {
+        // import { foo } from './foo.svg?url';
+        return;
+      }
+
       const importPathHasExtension = endsWith(importPath, extensions);
 
       if (importPathHasExtension) {

diff --git a/tests/fixtures/requireExtension/pathsImportIgnoreSearchParams/foo.svg b/tests/fixtures/requireExtension/pathsImportIgnoreSearchParams/foo.svg
diff --git a/tests/fixtures/requireExtension/pathsImportIgnoreSearchParams/subject.ts b/tests/fixtures/requireExtension/pathsImportIgnoreSearchParams/subject.ts
@@ -0,0 +1,2 @@
+// @ts-expect-error ignore search params
+import { foo } from './foo.svg?url';
diff --git a/tests/fixtures/requireExtension/pathsImportIgnoreSearchParams/tsconfig.json b/tests/fixtures/requireExtension/pathsImportIgnoreSearchParams/tsconfig.json
@@ -0,0 +1,13 @@
+{
+  "compilerOptions": {
+    "baseUrl": ".",
+    "paths": {
+      "@/*": [
+        "*"
+      ]
+    }
+  },
+  "include": [
+    "."
+  ]
+}
diff --git a/tests/rules/requireExtension.ts b/tests/rules/requireExtension.ts
@@ -75,6 +75,7 @@ ruleTester.run('require-extension', rule, {
     invalidTest('exportAllDeclaration'),
   ],
   valid: [
+    validTest('pathsImportIgnoreSearchParams'),
     validTest('pathsImportIgnoreUnknownExtensions'),
     validTest('pathsImportWithExtension'),
     validTest('relativeImportIgnoreUnknownExtensions'),
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		// @ts-expect-error ignore search params
		import { foo } from './foo.svg?url';