fix: handle nested conditions

src/rules/preferReactLazy.ts

@@ -1,27 +1,29 @@
+import { type TSESTree } from '@typescript-eslint/utils';
 import { createRule } from '../utilities';
 
 type Options = [];
 
 type MessageIds = 'preferReactLazy';
 
+const findConditionalExpressionParent = (node: TSESTree.JSXOpeningElement) => {
+  let currentNode: TSESTree.Node = node;
+
+  while (currentNode.parent) {
+    currentNode = currentNode.parent;
+
+    if (currentNode.type === 'ConditionalExpression') {
+      return true;
+    }
+  }
+
+  return false;
+};
+
 export default createRule<Options, MessageIds>({
   create: (context) => {
     const imported: string[] = [];
 
     return {
-      ConditionalExpression(node) {
-        if (node.consequent.type === 'JSXElement') {
-          // @ts-expect-error TODO
-          const name = node.consequent.openingElement.name.name;
-
-          if (imported.includes(name)) {
-            context.report({
-              messageId: 'preferReactLazy',
-              node,
-            });
-          }
-        }
-      },
       ImportDeclaration(node) {
         for (const specifier of node.specifiers) {
           if (specifier.type !== 'ImportSpecifier') {
@@ -31,6 +33,21 @@ export default createRule<Options, MessageIds>({
           imported.push(specifier.imported.name);
         }
       },
+      JSXOpeningElement(node) {
+        // @ts-expect-error TODO
+        const name = node.name.name;
+
+        if (!findConditionalExpressionParent(node)) {
+          return;
+        }
+
+        if (imported.includes(name)) {
+          context.report({
+            messageId: 'preferReactLazy',
+            node,
+          });
+        }
+      },
     };
   },
   defaultOptions: [],

tests/fixtures/preferReactLazy/invalid/jsxConditionalExpression/subject.tsx

@@ -0,0 +1,8 @@
+import React from 'react';
+import { Foo } from './Foo';
+
+export default () => {
+  return <>
+    {Math.random() > 0.5 ? <Foo /> : null}
+  </>;
+};

tests/fixtures/preferReactLazy/invalid/nestedJsxConditionalExpression/Foo.tsx

@@ -0,0 +1,3 @@
+export const Foo = () => {
+  return null;
+};

tests/fixtures/preferReactLazy/invalid/nestedJsxConditionalExpression/subject.tsx

@@ -0,0 +1,10 @@
+import React from 'react';
+import { Foo } from './Foo';
+
+export default () => {
+  return <>
+    {Math.random() > 0.5 ? <div>
+      <Foo />
+    </div> : null}
+  </>;
+};

tests/fixtures/preferReactLazy/invalid/returnConditionalExpression/Foo.tsx

@@ -0,0 +1,3 @@
+export const Foo = () => {
+  return null;
+};

tests/rules/preferReactLazy.ts

@@ -50,6 +50,10 @@ const validTest = (name: string, only: boolean = false) => {
 };
 
 ruleTester.run('prefer-react-lazy', rule, {
-  invalid: [invalidTest('staticImport')],
+  invalid: [
+    invalidTest('jsxConditionalExpression'),
+    invalidTest('nestedJsxConditionalExpression'),
+    invalidTest('returnConditionalExpression'),
+  ],
   valid: [validTest('dynamicImport')],
 });