Rename mutable to managed #109
Open
+73
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To stay consistent with Galaxy's terminology
|
Also, ref galaxyproject/galaxy#9362 |
hexylena
reviewed
Mar 16, 2020
| @@ -12,7 +12,7 @@ galaxy_manage_paths: no | |||
| galaxy_manage_clone: yes | |||
| galaxy_manage_download: no | |||
| galaxy_manage_static_setup: yes | |||
| galaxy_manage_mutable_setup: yes | |||
| galaxy_manage_managed_setup: yes | |||
There was a problem hiding this comment.
Suggested change
| galaxy_manage_managed_setup: yes | |
| galaxy_manage_managed_setup: "{{ galaxy_manage_mutable_setup | default(yes) }}" |
maybe something like this to ensure that people who don't read the upgrade notice can use the legacy value? @natefoo what are your opinions on that. "Read the release notes or else?"
There was a problem hiding this comment.
I have no objections. @natefoo - up to you?
There was a problem hiding this comment.
Yes, and we'll need to default all the other changed vars as well.
There was a problem hiding this comment.
Coolie. Sorry for the extra work, but figure it'll be a bit more userfriendly.
There was a problem hiding this comment.
It shouldn't be too bad as you can do:
galaxy_managed_data_dir: "{{ galaxy_mutable_data_dir }}"Rather than defaulting each instance of its usage. Hopefully that all plays nicely with the layout stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To stay consistent with Galaxy's terminology
Note: "manage 'managed'" is rather awkward and "manage 'galaxy-managed'" may be less so; but in the big picture 'galaxy-managed' creates more inconsistency even across this repo alone, so it's not worth it, IMHO.
Ref: galaxyproject/galaxy#9444