Refactor workflowID handling

To use undefined instead of an empty string and improve conditional checks
galaxyproject · Jan 31, 2025 · f77d4c6 · f77d4c6
1 parent cc26ff9
commit f77d4c6
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/client/src/components/Markdown/Markdown.vue b/client/src/components/Markdown/Markdown.vue
@@ -130,7 +130,7 @@ export default {
             workflows: {},
             invocations: {},
             loading: true,
-            workflowID: "",
+            workflowID: undefined,
         };
     },
     computed: {
@@ -159,7 +159,7 @@ export default {
             return "unavailable";
         },
         workflowVersions() {
-            return this.getStoredWorkflowByInstanceId(this.workflowID);
+            return this.workflowID ? this.getStoredWorkflowByInstanceId(this.workflowID) : undefined;
         },
         version() {
             return this.markdownConfig.generate_version || "Unknown Galaxy Version";
@@ -172,7 +172,9 @@ export default {
     },
     created() {
         this.initConfig();
-        this.fetchWorkflowForInstanceId(this.workflowID);
+        if (this.workflowID) {
+            this.fetchWorkflowForInstanceId(this.workflowID);
+        }
     },
     methods: {
         ...mapActions(useWorkflowStore, ["getStoredWorkflowByInstanceId", "fetchWorkflowForInstanceId"]),
@@ -188,7 +190,7 @@ export default {
                 this.workflows = config.workflows || {};
                 this.invocations = config.invocations || {};
                 this.loading = false;
-                this.workflowID = Object.keys(this.markdownConfig?.workflows ?? {})[0] ?? "";
+                this.workflowID = Object.keys(this.markdownConfig?.workflows ?? {})[0];
             }
         },
         splitMarkdown(markdown) {