-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gulp build improvements, update. #19405
base: dev
Are you sure you want to change the base?
Conversation
So the new gulp is failing on a step that has apparnetly been failing for a while now, just silently. Will update. |
…of these with this mechanism anymore. I hope.
built. Additional code cleanup. Rebase me -- bug where we should write a modified hash when changes are outstanding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is now way faster, specially when you already have the dependencies installed but don't have internet access 👍
(Waiting for a test rerun related to one of the visualizations)
I switched back to node 20 and now it still fails locally (it cannot find index.js and index.css for the plugin), so it is not related to the node version, sorry for the noise. It might have worked because I had prebuilt visualizations from other branches. |
Support --limit in gulp's viz plugin building, to isolate particular plugins or sets for rebuilding. Also updates to the (surprisingly) new gulp 5, which drops a slew of older dependencies. WIP in another branch to just de-gulpify all this, but it's not a priority right now; I just wanted to pop this out a set of various other viz fixes I'm working on getting in.
i.e.
yarn run gulp pluginsRebuild --limit nora
How to test the changes?
(Select all options that apply)
License