Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulp build improvements, update. #19405

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

dannon
Copy link
Member

@dannon dannon commented Jan 14, 2025

Support --limit in gulp's viz plugin building, to isolate particular plugins or sets for rebuilding. Also updates to the (surprisingly) new gulp 5, which drops a slew of older dependencies. WIP in another branch to just de-gulpify all this, but it's not a priority right now; I just wanted to pop this out a set of various other viz fixes I'm working on getting in.

i.e. yarn run gulp pluginsRebuild --limit nora

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.0 milestone Jan 14, 2025
@dannon
Copy link
Member Author

dannon commented Jan 15, 2025

So the new gulp is failing on a step that has apparnetly been failing for a while now, just silently. Will update.

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is now way faster, specially when you already have the dependencies installed but don't have internet access 👍

(Waiting for a test rerun related to one of the visualizations)

@davelopez
Copy link
Contributor

davelopez commented Jan 29, 2025

Hmmm, it seems lib/galaxy_test/selenium/test_visualizations.py::TestVisualizations::test_charts_h5web fails consistently in CI. I checked locally and it passes for me, I'm using node 20, so I switched to node 18 (like in CI) and the plugin doesn't load.
Now that I think of it, I vaguely remember we talked about updating the node version in one of the meetings... but I don't recall the reason, maybe it was because of this? (sorry, fish memory... 😅)

I switched back to node 20 and now it still fails locally (it cannot find index.js and index.css for the plugin), so it is not related to the node version, sorry for the noise. It might have worked because I had prebuilt visualizations from other branches.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants