-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong URI written to ExportObjectResultMetadata
when exporting histories to eLabFTW
#19541
Fix wrong URI written to ExportObjectResultMetadata
when exporting histories to eLabFTW
#19541
Conversation
…histories to eLabFTW Fix history exports to eLabFTW having a wrong URI saved to `ExportObjectResultMetadata.uri`, which results in not being able to reimport the histories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Hah!, right, there are some legit failures here 😅 |
The new version of |
Ahh! I see! Thanks for checking, some of the errors were suspiciously related to file sources 😅
But I see now that they are also failing in other PRs |
Yes, I also saw these errors when I opened the PR for the initial implementation. Counterintuitively, they don't seem to be a bug haha. |
This PR was merged without a "kind/" label, please correct. |
Fix history exports to eLabFTW having a wrong URI saved to
ExportObjectResultMetadata.uri
, which results in not being able to reimport the histories.How to test the changes?
(Select all options that apply)
License