Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Icons #19600

Draft
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

ElectronicBlueberry
Copy link
Member

Remove all string and class icons and replace them with typed IconDefinitions.
Improves tree shaking and should enable us to remove the bundling of all font awesome icons, which we are currently doing.

If icons are used by unused code, this PR removes that code entirely. Also some small refactoring to typescript and composition, where this removes related code complexity.

One remaining question mark is plugins (web-hooks). My current thinking is that we could provide a small per-selected set of icons for web-hooks to use, adding those manually with library.add and documenting which ones are supported.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant