Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all string and class icons and replace them with typed IconDefinitions.
Improves tree shaking and should enable us to remove the bundling of all font awesome icons, which we are currently doing.
If icons are used by unused code, this PR removes that code entirely. Also some small refactoring to typescript and composition, where this removes related code complexity.
One remaining question mark is plugins (web-hooks). My current thinking is that we could provide a small per-selected set of icons for web-hooks to use, adding those manually with
library.add
and documenting which ones are supported.How to test the changes?
(Select all options that apply)
License