-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes to tool_data_table_conf and related files for clair3 and artic #6790
Open
pvanheus
wants to merge
54
commits into
galaxyproject:main
Choose a base branch
from
pvanheus:update_clair3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,104
−107
Open
Changes from 3 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
298cadd
mmuphin wrapper draft with errors
renu-pal ef26199
Update .shed.yml
renu-pal 801cc88
removing long description from .shed.yml
renu-pal f0ca96f
Update tools/mmuphin/macros.xml
renu-pal c19da4d
Update tools/mmuphin/macros.xml
renu-pal 52076ec
Update tools/mmuphin/macros.xml
renu-pal bab0879
Update tools/mmuphin/macros.xml
renu-pal 7c09803
Update tools/mmuphin/macros.xml
renu-pal f340c26
Update tools/mmuphin/mmuphin.xml
renu-pal 4ee8d65
reducing CRC_abd file size and adding adjust_batch.R file
renu-pal e861c0f
adding long description into .shed.yml due to linting issue
renu-pal f65885e
Update .shed.yml
renu-pal 7fafc59
Update .shed.yml
renu-pal f79c79f
update
paulzierep 1b335f1
update
paulzierep d86e487
rm unneeded requs
paulzierep 47d426d
Merge pull request #4 from paulzierep/mmuphin_wrapper
renu-pal f815e86
changing batch value in test, as first column header is null
renu-pal f36aa66
removing control_output from test
renu-pal 090b476
reducing file size
renu-pal c5af559
Update mmuphin.xml
renu-pal e60c159
fixed tests
paulzierep 9c404da
Merge pull request #5 from paulzierep/mmuphin_wrapper
renu-pal 7c2d2d7
Update tools/mmuphin/mmuphin.xml
renu-pal c1b167c
getting column names in R directly
renu-pal 550cd60
Apply suggestions from code review
bgruening 8d38c99
removed unnecessary commented code
renu-pal b6e9c39
Update tools/mmuphin/mmuphin.xml
renu-pal 5109992
improving help section
renu-pal 0c902c3
Update tools/mmuphin/mmuphin.xml
renu-pal 19a33c0
removing additional options
renu-pal 663287a
Update tools/mmuphin/mmuphin.xml
renu-pal a139a38
adding test with covariate=null and few other updates
renu-pal ed1d307
mak covariates optional with python
paulzierep 9195bf8
Merge pull request #6 from paulzierep/mmuphin_wrapper
renu-pal 591e5b3
adding test case with multiple covariates
renu-pal fa3e8a5
Update tools/mmuphin/mmuphin.xml
renu-pal a968744
Update tools/mmuphin/mmuphin.xml
renu-pal e74fa15
suggested min max convergence value
renu-pal 243f1fc
adding filter in O/P and min max in conv
renu-pal d5b2dcd
Fix up tool_data_table_conf files
pvanheus a26b512
Remember to save this time
pvanheus ef8d97b
Fix columns in test-data
pvanheus 9fe39fd
Update artic: add primer scheme download and some small enhancements …
pvanheus 836f979
Minor update to tools/ncbi datasets (#6797)
SaimMomin12 a3bca79
New tool addition: MerquryFK ASMPlot (#6786)
SaimMomin12 9d6123a
Merge pull request #6584 from renu-pal/mmuphin_wrapper
bgruening e44d3cd
Correct tool data table name
pvanheus c6d65d9
Update starAMR DM version (#6802)
hugolefeuvre d5a83e7
Fix up tool_data_table_conf files
pvanheus 3b548fd
Remember to save this time
pvanheus dbdf06c
Fix columns in test-data
pvanheus 4d11cd2
Correct tool data table name
pvanheus a3740ec
Merge branch 'update_clair3' of github.com:pvanheus/tools-iuc into up…
wm75 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
<description>germline small variant caller for long-reads</description> | ||
<macros> | ||
<token name="@TOOL_VERSION@">1.0.10</token> | ||
<token name="@VERSION_SUFFIX@">1</token> | ||
<token name="@VERSION_SUFFIX@">2</token> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. don't bump this version so that we can overwrite the faulty previous attempt |
||
</macros> | ||
<xrefs> | ||
<xref type='bio.tools'>clair3</xref> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,10 @@ | ||
#Enter the model names in the second column, the platform name in the second and the path in the third. | ||
#This file lists the locations and dbkeys of all the model files | ||
#under the "models" directory (a directory that contains a directory | ||
#This file lists the names and locations of all the clair3 model files | ||
#under the "clair3_models" directory (a directory that contains a directory | ||
#for each build). This file has the format (white space characters are | ||
#TAB characters): | ||
# | ||
#<unique_build_id> <display_name> <platform> <file_path> <source> | ||
#<unique_name> <platform> <sha256sum> <file_path> <source> | ||
# | ||
#So, all_model.loc could look something like this: | ||
test_model "the_model_name" ont $(dirname $(which run_clair3.sh))/models/r941_prom_hac_g360+g422 clair3 | ||
r1041_e82_400bps_sup_v500 r1041_e82_400bps_sup_v500 ont /no/such/model rerio | ||
#So, clair3_models.loc could look something like this: | ||
test_model ont $(dirname $(which run_clair3.sh))/models/r941_prom_hac_g360+g422 clair3 | ||
r1041_e82_400bps_sup_v500 ont 01c05768661bdd7de611e6bae1043c43b7523a54b223e029c683bfac0db7a678 /no/such/model rerio |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
#This file lists the names and locations of all the clair3 model files | ||
#under the "clair3_models" directory (a directory that contains a directory | ||
#for each build). This file has the format (white space characters are | ||
#TAB characters): | ||
# | ||
#<unique_name> <platform> <sha256sum> <file_path> <source> | ||
# | ||
#So, clair3_models.loc could look something like this: | ||
test_model ont $(dirname $(which run_clair3.sh))/models/r941_prom_hac_g360+g422 clair3 |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this entire file still needs to be renamed to
clair3_models.loc.sample
I guess.Then the tool_data_table.conf needs to be adjusted too.