-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated autoBIGS tool #6815
base: main
Are you sure you want to change the base?
Updated autoBIGS tool #6815
Conversation
Failed linting |
@RealYHD Please add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The from_url
feature has been introduced only in 24.0 galaxyproject/galaxy#17087
So I think this should be the minimal version, or is the tool still usable in older galaxy versions?
@RealYHD in the test specify the conditional
to
|
Hi @bernt-matthias, thanks for that catch. Unfortunately, no, it would no longer be usable. I will need to change a few of the inputs. I did not see this listed on the tool XML changelogs, hence my lapse in judgement. I should have, and will be more careful going forward. As a side note, this may be a good addition to the list of behaviour changes? 😛 Thank you everyone for your very helpful input. I've converted this PR into a draft as this turned out to be a much more complicated change than I initially thought. I will work on these items and mark it as ready for review after more thorough testing. |
How? What would be your idea?
If we would include every new feature in this list, it would cover most of the Galaxy's changelog. This list is about changed behavior only (so called profile versions where we change Galaxy's behavior depending on tool version). |
Simply lowers the minimum Galaxy version that should be required to run this tool.
FOR CONTRIBUTOR: