Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pixell sharp dependency #183

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Remove pixell sharp dependency #183

merged 7 commits into from
Jul 25, 2024

Conversation

msyriac
Copy link
Contributor

@msyriac msyriac commented May 29, 2024

This fixes #178

@zonca
Copy link
Member

zonca commented May 29, 2024

@msyriac feel free to update minimum python in Github Action or notify me to take care of that

@msyriac
Copy link
Contributor Author

msyriac commented May 29, 2024

I have now, but there seems to be a numpy related error. I might not have time to look into this until next week!

@itrharrison
Copy link

itrharrison commented May 30, 2024

I think the problem is that pixell's setup.py imports various numpy things but that requirement isn't satisfied when the setup gets run.

Adding numpy to the pysm install_requires seems to fix (but ofc I can't push to Mat's fork).

@zonca
Copy link
Member

zonca commented Jun 3, 2024

@itrharrison if you'd like to open another PR and fix this it would be much appreciated!

@zonca
Copy link
Member

zonca commented Jun 20, 2024

@itrharrison do you have a branch where you tested this?

@itrharrison
Copy link

No, sorry, I have been trying but no matter where I add numpy the same problem appears. You can see here:
https://github.com/itrharrison/pysm/pull/1/files

I guess the other option would be for pixell to remove the numpy imports from its setup.py

@zonca
Copy link
Member

zonca commented Jun 21, 2024

Thank you very much for your help with this. I was wondering, is it possible this has something to do with numpy 2.0?
Does it make a difference if we set to avoid numpy.2?

@zonca
Copy link
Member

zonca commented Jun 22, 2024

@zonca
Copy link
Member

zonca commented Jun 22, 2024

my hope is that putting numpy in setup_requires on pixell fixes this issue

@zonca
Copy link
Member

zonca commented Jun 22, 2024

@itrharrison would you like to create a branch of pixell with this fix, then setup Github Actions in your branch of PySM to install pixell from that git branch and see if everything magically works (I know I'm an optimist!).
If so, we (meaning you of course) can then contribute this fix to pixell.

@zonca zonca merged commit 2b69973 into galsci:main Jul 25, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while returning a CAR map
3 participants