-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pixell sharp dependency #183
Conversation
@msyriac feel free to update minimum python in Github Action or notify me to take care of that |
I have now, but there seems to be a numpy related error. I might not have time to look into this until next week! |
I think the problem is that pixell's setup.py imports various numpy things but that requirement isn't satisfied when the setup gets run. Adding numpy to the pysm |
@itrharrison if you'd like to open another PR and fix this it would be much appreciated! |
@itrharrison do you have a branch where you tested this? |
No, sorry, I have been trying but no matter where I add numpy the same problem appears. You can see here: I guess the other option would be for pixell to remove the numpy imports from its setup.py |
Thank you very much for your help with this. I was wondering, is it possible this has something to do with numpy 2.0? |
@itrharrison maybe we should open a PR on pixell implementing this? @msyriac? |
my hope is that putting |
@itrharrison would you like to create a branch of pixell with this fix, then setup Github Actions in your branch of PySM to install pixell from that git branch and see if everything magically works (I know I'm an optimist!). |
This fixes #178