-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[firefox] can't be pulled in ARM (kubernetes) environment #204
Comments
We used to have them but then it became too much of a burden to maintain the inevitable broken packages on ARM, plus the Github runner was taking forever when using QEMU. Now we've got a free oracle ARM runner that we could use to speed building the images, I think it's worth re-evaluating this. |
I can have a look if you want, diff --git a/.github/workflows/auto-build.yml b/.github/workflows/auto-build.yml
index 30a84d5a697d..c39ec6b5ea8b 100644
--- a/.github/workflows/auto-build.yml
+++ b/.github/workflows/auto-build.yml
@@ -33,23 +33,28 @@ jobs:
strategy:
matrix:
image:
- - { name: xorg, platforms: "linux/amd64" }
- - { name: pulseaudio, platforms: "linux/amd64" }
- - { name: udevd, platforms: "linux/amd64" }
- - { name: sunshine, platforms: "linux/amd64" }
- - { name: retroarch, platforms: "linux/amd64" }
- - { name: firefox, platforms: "linux/amd64" }
- - { name: steam, platforms: "linux/amd64" }
- - { name: pegasus, platforms: "linux/amd64" }
- - { name: lutris, platforms: "linux/amd64" }
- - { name: heroic-games-launcher, platforms: "linux/amd64" }
- #- { name: es-de, platforms: "linux/amd64" }
+ - name: xorg
+ - name: pulseaudio
+ - name: udevd
+ - name: sunshine
+ - name: retroarch
+ - name: firefox
+ - name: steam
+ - name: pegasus
+ - name: lutris
+ - name: heroic-games-launcher
+ platform:
+ - arch: "linux/amd64"
+ runner: "ubuntu-latest"
+ - arch: "linux/arm64"
+ runner: "arm64-runner" # => may need the runner tag here
fail-fast: false
uses: ./.github/workflows/docker-build-and-publish.yml
with:
image_name: "${{ matrix.image.name }}"
base_image: "${{ needs.base.outputs.image_tag }}"
base_app_image: "${{ needs.base-app.outputs.image_tag }}"
- platforms: "${{ matrix.image.platforms }}"
+ platforms: "${{ matrix.platform.arch }}"
+ runs-on: "${{ matrix.platform.runner }}"
secrets: inherit |
I was going to suggest a very simple first step of testing out building the Docker images locally on your ARM machine but I see you are getting straight into it! If you want to start a PR I'd be happy to authorize the run |
can you please add ARM specific target ?
tested with
ghcr.io/games-on-whales/firefox:edge
The text was updated successfully, but these errors were encountered: