Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firefox] can't be pulled in ARM (kubernetes) environment #204

Closed
DrummyFloyd opened this issue Jan 6, 2025 · 3 comments · Fixed by #206
Closed

[firefox] can't be pulled in ARM (kubernetes) environment #204

DrummyFloyd opened this issue Jan 6, 2025 · 3 comments · Fixed by #206

Comments

@DrummyFloyd
Copy link
Contributor

DrummyFloyd commented Jan 6, 2025

can you please add ARM specific target ?

tested with ghcr.io/games-on-whales/firefox:edge

@ABeltramo
Copy link
Member

We used to have them but then it became too much of a burden to maintain the inevitable broken packages on ARM, plus the Github runner was taking forever when using QEMU.

Now we've got a free oracle ARM runner that we could use to speed building the images, I think it's worth re-evaluating this.
Would you like to contribute? 😉

@DrummyFloyd
Copy link
Contributor Author

DrummyFloyd commented Jan 6, 2025

I can have a look if you want,
Just need some inputs :)

diff --git a/.github/workflows/auto-build.yml b/.github/workflows/auto-build.yml
index 30a84d5a697d..c39ec6b5ea8b 100644
--- a/.github/workflows/auto-build.yml
+++ b/.github/workflows/auto-build.yml
@@ -33,23 +33,28 @@ jobs:
     strategy:
       matrix:
         image:
-          - { name: xorg,                       platforms: "linux/amd64" }
-          - { name: pulseaudio,                 platforms: "linux/amd64" }
-          - { name: udevd,                      platforms: "linux/amd64" }
-          - { name: sunshine,                   platforms: "linux/amd64" }
-          - { name: retroarch,                  platforms: "linux/amd64" }
-          - { name: firefox,                    platforms: "linux/amd64" }
-          - { name: steam,                      platforms: "linux/amd64" }
-          - { name: pegasus,                    platforms: "linux/amd64" }
-          - { name: lutris,                     platforms: "linux/amd64" }
-          - { name: heroic-games-launcher,      platforms: "linux/amd64" }
-        #- { name: es-de,      platforms: "linux/amd64" }
+          - name: xorg
+          - name: pulseaudio
+          - name: udevd
+          - name: sunshine
+          - name: retroarch
+          - name: firefox
+          - name: steam
+          - name: pegasus
+          - name: lutris
+          - name: heroic-games-launcher
+        platform:
+          - arch: "linux/amd64"
+            runner: "ubuntu-latest"
+          - arch: "linux/arm64"
+            runner: "arm64-runner" # => may need the runner tag here
       fail-fast: false
     uses: ./.github/workflows/docker-build-and-publish.yml
     with:
       image_name: "${{ matrix.image.name }}"
       base_image: "${{ needs.base.outputs.image_tag }}"
       base_app_image: "${{ needs.base-app.outputs.image_tag }}"
-      platforms: "${{ matrix.image.platforms }}"
+      platforms: "${{ matrix.platform.arch }}"
+      runs-on: "${{ matrix.platform.runner }}"
     secrets: inherit

@ABeltramo
Copy link
Member

I was going to suggest a very simple first step of testing out building the Docker images locally on your ARM machine but I see you are getting straight into it!
The runner should be tagged ARM64, it's used in Wolf:

https://github.com/games-on-whales/wolf/blob/84be69bcc5c22e4c318ba0034eaa08376ad84543/.github/workflows/linux-build-test.yml#L16

If you want to start a PR I'd be happy to authorize the run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants