Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable automatic build of images for ARM #206

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Conversation

DrummyFloyd
Copy link
Contributor

@DrummyFloyd DrummyFloyd commented Jan 6, 2025

@ABeltramo close previous #205
to enable selfHosted runner as a organization Member with this PR
thank you 👍

EDIT: will sign my commit before merge dw

@ABeltramo
Copy link
Member

ABeltramo commented Jan 6, 2025

Looks like it's building both AMD64 and ARM images on the Github runner instead of splitting it across runners..

ex: https://github.com/games-on-whales/gow/pkgs/container/base/331970144?tag=sha-f48ea79

@DrummyFloyd
Copy link
Contributor Author

Looks like it's building both AMD64 and ARM images on the Github runner instead of splitting it across runners..

ex: https://github.com/games-on-whales/gow/pkgs/container/base/331970144?tag=sha-f48ea79

because the matrix with different platform are on apps stage and not base-app should i enable this mecanism also on base-app stage?

btw => dunno if you are aware of this, but i have *Merge authorization ..
image

NB: sorry i edit you comment instead of quote reply

@ABeltramo
Copy link
Member

because the matrix with different platform are on apps stage and not base-app should i enable this mecanism also on base-app stage?

Definitely, it's going to take forever otherwise..

btw => dunno if you are aware of this, but i have *Merge authorization ..

With great power comes great responsibility 😉

@DrummyFloyd
Copy link
Contributor Author

because the matrix with different platform are on apps stage and not base-app should i enable this mecanism also on base-app stage?

Definitely, it's going to take forever otherwise..

btw => dunno if you are aware of this, but i have *Merge authorization ..

With great power comes great responsibility 😉

will change that so !

@DrummyFloyd DrummyFloyd force-pushed the 204-arm-target branch 25 times, most recently from 9096be0 to d9d8788 Compare January 7, 2025 13:11
@DrummyFloyd DrummyFloyd force-pushed the 204-arm-target branch 9 times, most recently from d2e9e37 to 49a42e3 Compare January 7, 2025 16:35
@DrummyFloyd
Copy link
Contributor Author

work as expectd , with possibilties to enable each image for wanted platforms

image

CI: adding `.github` to the paths that triggers a build run
CI: adding more PR types
@DrummyFloyd
Copy link
Contributor Author

should we add also
arm64 build for

  • xorg
  • retroarch
  • pulseaudio
  • sunshine
  • steam

Added comment and removed old udevd image
disabled Retroarch build on ARM, doesn't work
@ABeltramo ABeltramo changed the title 204 arm target Enable automatic build of images for ARM Jan 9, 2025
@ABeltramo
Copy link
Member

Thanks for your hard work on this, I think we're good to go!
I'll let CI finish and make another run just to see if the buildcache is properly working before merging..

@DrummyFloyd DrummyFloyd linked an issue Jan 9, 2025 that may be closed by this pull request
@ABeltramo ABeltramo merged commit b842a1c into master Jan 9, 2025
38 checks passed
@ABeltramo ABeltramo deleted the 204-arm-target branch January 9, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firefox] can't be pulled in ARM (kubernetes) environment
2 participants