Deleting all legacy PACKAGE.py

[souravpy]

Deleted following files as remarked

./GangaCore/PACKAGE.py
./GangaDirac/PACKAGE.py
./GangaGaudi/PACKAGE.py
./GangaLHCb/PACKAGE.py
./GangaND280/PACKAGE.py
./GangaTest/Lib/GListApp/PACKAGE.py
./GangaTest/Lib/TFile/PACKAGE.py
./GangaTest/PACKAGE.py
./GangaTutorial/PACKAGE.py

[egede]

Some tests are failing, reporting a failure of import GangaCore.PACKAGE. It should be investigated if those lines can just be deleted.

[egede]

The PackageSetup class should be deleted as well.

[souravpy]

The PackageSetup class should be deleted as well.

Done as suggested, kindly check the PR

[egede]

We see a set of failures in the testing here, that I assume is a side effect of the code that has been removed.

/home/runner/venv/lib/python3.11/site-packages/coverage/inorout.py:503: CoverageWarning: Module ganga/GangaCore/PACKAGE.py was never imported. (module-not-imported)
  self.warn(f"Module {pkg} was never imported.", slug="module-not-imported")
/home/runner/venv/lib/python3.11/site-packages/coverage/inorout.py:503: CoverageWarning: Module ganga/GangaCore/__init__.py was never imported. (module-not-imported)
  self.warn(f"Module {pkg} was never imported.", slug="module-not-imported")
/home/runner/venv/lib/python3.11/site-packages/coverage/report_core.py:109: CoverageWarning: Couldn't parse Python file '/home/runner/work/ganga/ganga/ganga/GangaCore/Utility/Setup.py' (couldnt-parse)
  coverage._warn(msg, slug="couldnt-parse")
collecting ... collected 139 items / 2 errors

==================================== ERRORS ====================================
_____ ERROR collecting ganga/GangaCore/test/Unit/Notebook/TestNotebook.py ______
ImportError while importing test module '/home/runner/work/ganga/ganga/ganga/GangaCore/test/Unit/Notebook/TestNotebook.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
ganga/GangaCore/test/Unit/Notebook/TestNotebook.py:15: in <module>
    from GangaCore.Lib.Notebook import Notebook
ganga/GangaCore/Lib/Notebook/__init__.py:2: in <module>
    from .Notebook import Notebook
E   ModuleNotFoundError: No module named 'GangaCore.Lib.Notebook.Notebook'

I think the first step is to understand the warinings and the reason for the failure of the import. The nthe fix might actually be easy.

[mesmith75]

I think this has gone in the wrong direction - we want to keep the Notebook, not remove it.

[souravpy]

I think this has gone in the wrong direction - we want to keep the Notebook, not remove it.

I'm keeping it, just omitting the line that is giving error on import, I'll fix it asap!

[mesmith75]

I'm not sure I understand - it gives you the error because you deleted the file. You need to keep the file and that import.

[egede]

@souravpy I fixed the collision caused by the file that was removed/restored. When developing code on a fork, please use a branch rather than the just the main branch (called develop here). In the way you have done it here, you have granted all Ganga developers write access to the main branch in your fork. Probably not what you wanted.