nd280 updates for 2024/2025 #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickHastings
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
alexanderrichards
previously approved these changes
Jan 8, 2025
|
Had a quick look but I don't see what needs to be done to get the failing checks to pass. Any hints? |
|
@NickHastings You are seeing a weakness of our CI. If the PR branch of your fork doesn't allow for the Ganga developers to edit (a box that you can tick or not), then the PEP8 compliance testing will fail. As all your changes are within the |
egede
reviewed
Jan 13, 2025
NickHastings
force-pushed
the
feature/nd280-2024
branch
from
efb5538 to
0d13df4
Compare
NickHastings
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
NickHastings
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
NickHastings
changed the title
NickHastings
force-pushed
the
feature/nd280-2024
branch
from
88cfcb1 to
282b790
Compare
NickHastings
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
NickHastings
force-pushed
the
feature/nd280-2024
branch
from
282b790 to
7ef9f10
Compare
NickHastings
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
NickHastings
force-pushed
the
feature/nd280-2024
branch
from
7ef9f10 to
a39f32c
Compare
NickHastings
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
NickHastings
force-pushed
the
feature/nd280-2024
branch
from
a39f32c to
5be6f5e
Compare
NickHastings
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
|
Hmm, all the discussion/comments after the first few days seems to have disappeared... |
|
I resolved the discussion, but it should still be there (but slightly hidden). |
|
@NickHastings Any updates? |
NickHastings
changed the title
- Remove obsolete _GUIPrefs and _GUIAdvancedPrefs - Indenting, imports, and other style updates
NickHastings
force-pushed
the
feature/nd280-2024
branch
from
5be6f5e to
8c91be1
Compare
NickHastings
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
|
Sorry, forgot about this. Just now I rebased from develop, so I think it should be fine to merge. |
egede
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch has two minor feature updates for ND280 processing and some code cleanups.