Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor performance improvements and a fix of case of variable overwrititing #5484

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Minor performance improvements and a fix of case of variable overwrititing #5484

merged 4 commits into from
Aug 18, 2023

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Aug 12, 2023

  • IsomorphicSubgroups prefers smaller orders for subgroup generators, if subgroup is small
  • Nice group element test recognized generators first
  • Matrix group nice monomorphism degree improvement can be toned down with cheap option
  • Fix overuse of variable in double coset computation, leads to error message
    (Test example is too big to include in distribution, is attached:
    gcbug.txt
    )

@hulpke
ENHANCE: Use of cheap option in matgrp
e7fbf14 
can be used to avoid reducing perm degree
@hulpke
ENHANCE: element test in nice groups
abacbd5 
Do not force nice monomorphism, if it is a generator
@hulpke
FIX: Over-used variable
8cbecda
@hulpke hulpke added kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: performance improvement release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Aug 12, 2023
@hulpke
ENHANCE IsomorphicSubgroups generators
c334dde 
choose with preference for lower orders.
@hulpke hulpke changed the title Minor performance improvements and a fix in prior improvement Minor performance improvements and a fix of case of variable overwrititing Aug 13, 2023
fingolfin
fingolfin approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fingolfin fingolfin merged commit ea41bf9 into gap-system:master Aug 18, 2023
22 checks passed
@fingolfin fingolfin added the topic: performance bugs or enhancements related to performance (improvements or regressions) label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: performance bugs or enhancements related to performance (improvements or regressions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hulpke @fingolfin