-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MaximalSubgroupClassReps uses AtlasRep if available #5485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good to me but it wouldn't hurt if @ThomasBreuer had another look, perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is:
If AtlasRep provides information about the group in question then does it have SLPs for computing representatives for all classes of maximal subgroups?
In order to decide this, one can do the following.
info:= AtlasRepInfoRecord( name );
IsBound( info.nrMaxes ) and info.slpMaxes[1] = [ 1 .. info.nrMaxes ] and ForAll( info.slpMaxes[2], l -> 1 in l );
If the result is true
then one can proceed as in the proposed code: Compute standard generators and use the SLPs directly if there is a find
script, and compute an isomorphisms of groups and use AtlasSubgroup
otherwise.
if available
@ThomasBreuer does this seem OK to you now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
The code looks correct now, just two lines could be simplified.
Co-authored-by: Thomas Breuer <[email protected]>
Thank you! I applied @ThomasBreuer tweaks (after double checking), this will auto-merge once the test suite passed |
MaximalSubgroupClassReps method for simple groups that uses AtlasRep, if thee package is available and can handle the group.