Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NaturalGModule for obtaining the natural module of a matrix group #5798

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

fingolfin
Copy link
Member

Also fix usage error message for GModuleByMats.

The main gist is: instead of this

g:= SP(4, 2);;
m:= GModuleByMats( GeneratorsOfGroup( g ), GF(2) );;

you can now write this

g:= Sp(4, 2);;
m:= GModuleByGroup( g );;

which just is quite convenient when dealing with matrix groups over finite fields.

A field can be specified as an optional second argument in case the matrix groups is defined over one field, but we want the module over another. But perhaps I should just drop it?

This is a draft, as there is no documentation yet for the new function (just a placeholder), and also a TODO comment here or there in the code.

Before I fine tune it I wanted to check if this seems sensible. Also I wonder whether the function's name should be changed to e.g. just GModule, or perhaps NaturalGModule, or something else.

Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

I think NaturalGModule would be a natural name; this term occurs for example in the description of PermutationGModule.

If the function shall eventually cover also the case of permutation groups then the argument that specifies the field cannot be avoided; then perhaps PermutationGModule need not be documented anymore.

(Perhaps for another pull request: The check of arguments of GModuleByMats can be improved; a given dimension is ignored if the list of matrices is nonempty, and it is not checked that the matrices really fit together; for example, GAP accepts the input GModuleByMats([[[Z(2)]], [[1]]], GF(2)).)

@fingolfin fingolfin added this to the GAP 4.14.0 milestone Oct 13, 2024
@fingolfin fingolfin marked this pull request as ready for review October 13, 2024 09:21
@fingolfin fingolfin changed the title Add GModuleByGroup helper Add NaturalGModule for obtaining the natural module of a matrix group Oct 13, 2024
@fingolfin fingolfin force-pushed the mh/GModuleByGroup branch 2 times, most recently from ab353f2 to 6a72ec1 Compare October 13, 2024 09:26
Also fix usage error message for GModuleByMats
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the tests is failing, a cross-reference should be adjusted.
(This is actually not an error in the sense of GAPDoc, but somehow more rules are imposed on the GAP manuals; unfortunately some of these rules are wrong.)

doc/ref/meataxe.xml Outdated Show resolved Hide resolved
Co-authored-by: Thomas Breuer <[email protected]>
@ThomasBreuer ThomasBreuer self-requested a review October 16, 2024 07:48
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the tests pass.

@ThomasBreuer ThomasBreuer merged commit f3d876f into gap-system:master Oct 16, 2024
33 checks passed
@fingolfin fingolfin deleted the mh/GModuleByGroup branch October 16, 2024 14:09
@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes kind: new feature labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements kind: new feature release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants