Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: cleanup vararg argument names #5821

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

fingolfin
Copy link
Member

The kernel automatically adds the ... so we don't have to do it.

Before:

gap> Print;
function( arg...... ) ... end

After

gap> Print;
function( arg... ) ... end

Since this is a purely cosmetic triviality I am not bothering
to add a test.

The kernel automatically adds the `...` so we don't have to do it.

Before:

    gap> Print;
    function( arg...... ) ... end

After

    gap> Print;
    function( arg... ) ... end

Since this is a purely cosmetic triviality I am not bothering
to add a test.
@fingolfin fingolfin added topic: kernel release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Oct 22, 2024
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
It fixes also Print( Print ), which was even uglier:

Before:

gap> Print( Print );
function ( arg\.\.\.... )
    <<kernel code>> from src/streams.c:Print
end

After:

gap> Print( Print );
function ( arg... )
    <<kernel code>> from src/streams.c:Print
end

@fingolfin fingolfin merged commit ee6111c into gap-system:master Oct 24, 2024
31 of 33 checks passed
@fingolfin fingolfin deleted the mh/arg-dot-dot-dot branch October 24, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants