-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate deployment of monitoring
stack to flux
#3009
Migrate deployment of monitoring
stack to flux
#3009
Conversation
7af3029
to
58a0e67
Compare
58a0e67
to
d425ccf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, love it! Thanks for finishing the last item of this effort 🚀
I don't have much to comment :)
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks again!
Leaving a
/hold
in case you want to watch/control the rollout of this change closely. Just remove it when you're ready :)
LGTM label has been added. Git tree hash: 89dcc32d4be03270cb7f8c3e7bdcf46b934c3718
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
@oliver-goetz: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind enhancement
What this PR does / why we need it:
This is the final step on our journey from deploying the components of the prow clusters via a custom
deploy.sh
to a deployment withflux
.This PR migrates the prow monitoring stack to
flux
. Unlike the other changes this also includes a switch fromkube-prometheus
tokube-prometheus-stack
helm chart.It is easier to deploy
kube-prometheus-stack
viaflux
, updated more frequently and you can configure it in a less resource consuming way.Finally,
deploy.sh
and thedeployer
service account have been dropped too, because we don't need them anymore 😄Which issue(s) this PR fixes:
Follow-up to #2812
Special notes for your reviewer:
/cc @timebertt
The new setup is already manually deployed to our prow clusters.