Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deployment of monitoring stack to flux #3009

Merged

Conversation

oliver-goetz
Copy link
Member

/kind enhancement

What this PR does / why we need it:
This is the final step on our journey from deploying the components of the prow clusters via a custom deploy.sh to a deployment with flux.

This PR migrates the prow monitoring stack to flux. Unlike the other changes this also includes a switch from kube-prometheus to kube-prometheus-stack helm chart.
It is easier to deploy kube-prometheus-stack via flux, updated more frequently and you can configure it in a less resource consuming way.

Finally, deploy.sh and the deployer service account have been dropped too, because we don't need them anymore 😄

Which issue(s) this PR fixes:
Follow-up to #2812

Special notes for your reviewer:
/cc @timebertt

The new setup is already manually deployed to our prow clusters.

@gardener-prow gardener-prow bot requested a review from timebertt January 10, 2025 18:23
@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 10, 2025
@oliver-goetz oliver-goetz force-pushed the enh/flux-prometheus-operator branch from 7af3029 to 58a0e67 Compare January 10, 2025 19:19
@oliver-goetz oliver-goetz force-pushed the enh/flux-prometheus-operator branch from 58a0e67 to d425ccf Compare January 10, 2025 19:42
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, love it! Thanks for finishing the last item of this effort 🚀
I don't have much to comment :)

clusters/prow-build/monitoring-build-kustomization.yaml Outdated Show resolved Hide resolved
config/prow/plugins.yaml Outdated Show resolved Hide resolved
@timebertt
Copy link
Member

/assign

Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks again!

Leaving a
/hold
in case you want to watch/control the rollout of this change closely. Just remove it when you're ready :)

@gardener-prow gardener-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 24, 2025
Copy link

gardener-prow bot commented Jan 24, 2025

LGTM label has been added.

Git tree hash: 89dcc32d4be03270cb7f8c3e7bdcf46b934c3718

Copy link

gardener-prow bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2025
@oliver-goetz
Copy link
Member Author

/unhold

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
@gardener-prow gardener-prow bot merged commit b0590b5 into gardener:master Jan 24, 2025
4 checks passed
Copy link

gardener-prow bot commented Jan 24, 2025

@oliver-goetz: Updated the plugins configmap in namespace prow at cluster gardener-prow-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

/kind enhancement

What this PR does / why we need it:
This is the final step on our journey from deploying the components of the prow clusters via a custom deploy.sh to a deployment with flux.

This PR migrates the prow monitoring stack to flux. Unlike the other changes this also includes a switch from kube-prometheus to kube-prometheus-stack helm chart.
It is easier to deploy kube-prometheus-stack via flux, updated more frequently and you can configure it in a less resource consuming way.

Finally, deploy.sh and the deployer service account have been dropped too, because we don't need them anymore 😄

Which issue(s) this PR fixes:
Follow-up to #2812

Special notes for your reviewer:
/cc @timebertt

The new setup is already manually deployed to our prow clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants