fix setError caller #2280
Open
fix setError caller #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
the loading screen on the shoot details page was displayed when the navigation was aborted (e.g. no access to shoot terminal) and did not transition to loaded state
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
grolu
reviewed
Feb 4, 2025
| @@ -184,7 +184,10 @@ export default { | |||
| if (this.error) { | |||
| const err = this.error | |||
| this.error = null | |||
| this.setError(err) | |||
| this.setError({ | |||
There was a problem hiding this comment.
while this fixes the issue, shouldn't we enhance the setAlertWithType in appStore to also support the message property as alternative to text. This ensures that the function works with error objects and prevents possible wrong usage in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
setErroris not called properly and thus (detail) information is missing when a error notification is shown.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: