Adds e2e test for compaction #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot-ci-3
added
reviewed/ok-to-test
|
/test pull-etcd-druid-e2e-kind |
seshachalam-yv
requested changes
Nov 17, 2023
There was a problem hiding this comment.
Thanks @abdasgupta for adding E2E tests
Please address my NIT comments
gardener-robot-ci-1
added
reviewed/ok-to-test
|
/test pull-etcd-druid-e2e-kind-alpha-features |
seshachalam-yv
approved these changes
Nov 21, 2023
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
|
@seshachalam-yv this PR will not pass until #726 is merged. Please rebase this on master once #726 has been merged |
seshachalam-yv
force-pushed
the
e2e-test
branch
from
d6a9806 to
16bda19
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot
added
the
status/closed
renormalize
pushed a commit
to renormalize/etcd-druid
that referenced
this pull request
Dec 12, 2023
* Added e2e tests for compaction. * Fetches options for ETCD Druid through skaffold. * Fixes compaction for distroless image of etcd backup-restore. * Address Sesha's second review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind test
What this PR does / why we need it:
This PR adds e2e test for compaction in druid
Which issue(s) this PR fixes:
Fixes #704
Special notes for your reviewer:
As we don't have the new release of etcd backup-restore that supports on demand latest snapshot fetch from actual object storage, I used a custom image of etcd backup-restore that support on-demand latest snapshot from actual object storage. Please, delete the commit with the name
Uses a custom etcdbrctl image that supports latest snapshot pulled from actual storage.from this PR, once a release is made for etcd backup-restore.Release note: