-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of *_STORAGE_API_ENDPOINT` environment variables for providers #856
Remove usage of *_STORAGE_API_ENDPOINT` environment variables for providers #856
Conversation
/assign @renormalize @unmarshall |
As discussed off GitHub with @shreyas-s-rao, passing domain in the The way to perform this is to add:
to the hosts file of the host machine where etcd-backup-restore tests are running so that However, it has to be kept in mind to not pass the Doing this will break the current way the Azurite make targets work in etcd-druid, so for a few commits Azurite will not be functional with etcd-druid for local development and testing. |
Added this as a point in #782 |
/hold until gardener/etcd-backup-restore#759 is merged, released and etcdbr version v0.30.0 is updated in druid. |
/unhold as gardener/etcd-backup-restore#759 is merged. |
2ac9b10
to
85f287d
Compare
@ashwani2k I've removed the temp commit now, so the PR can be merged once the tests pass. |
/test pull-etcd-druid-e2e-kind |
@ashwani2k can you please raise a PR to update etcdbr image to v0.30.0 in images.yaml, along with the relevant release notes? I'm surprised that the PR was not raised automatically. |
85f287d
to
0ca1ca1
Compare
/test pull-etcd-druid-e2e-kind-nondistroless-etcd |
0ca1ca1
to
dcbb59e
Compare
@ashwani2k I have rebased the PR, so it can now be merged, after the tests pass of course. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the v0.30.1
of etcd-backup-restore, and all behavior is as expected. Thanks.
How to categorize this PR?
/area security
/kind task
What this PR does / why we need it:
Remove usage of *_STORAGE_API_ENDPOINT` environment variables for providers, since credentials from secrets (including API endpoints) should not be passed as environment variables to the backup-restore container.
Which issue(s) this PR fixes:
Fixes gardener/etcd-backup-restore#727
Special notes for your reviewer:
/block
To be merged only after gardener/etcd-backup-restore#759 is merged, released and etcdbr version v0.30.0 is updated in druid.
For local testing purpose, I have included the PR build image from https://concourse.ci.gardener.cloud/teams/gardener/pipelines/etcd-backup-restore-master/jobs/master-pull-request-job/builds/37. This commit will be removed before merging.
@renormalize please let me know if we can pass
domain
to Azurite (with formathttp(s)://<storageAccount>.<domain>
) instead of the entire URL.Release note: